feat(textures): configurable texture offset + setTextureOptions#253
Merged
Conversation
Apply and persist Texture.offset alongside the existing repeat handling in Element.setTexture, so offset round-trips through serialization and game builds the same way repeat does. Add Element.setTextureOptions(type, options) to update an already-assigned texture's repeat/offset by merging into its recorded options and re-applying, without reloading the texture. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds support for a texture's offset and a way to update an assigned texture's tiling options without reloading it.
Element.setTexturenow readsoffsetfrom options, applies it (texture.offset.set(...)), and records it alongsiderepeat/wrap— so it serializes intoEntityConfigurationand round-trips through save/reload and game builds, exactly likerepeatalready did.Element.setTextureOptions(type, options)merges new options (e.g.{ repeat }or{ offset }) into the texture's recorded options and re-applies them to the material — no texture reload.Why
repeatwas already applied/persisted butoffsetwas silently ignored (never recorded, never applied). The editor needs a lightweight way to tweak repeat/offset on an already-assigned texture;setTextureOptionsprovides that.Testing
npm test→ 505/505 pass (29 suites).npm run build→dist/mage.jsbuilds clean.Companion PR
Editor wiring: MageStudio/mage-studio#297
🤖 Generated with Claude Code